Update plugins docs #1321
Merged
Update plugins docs #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| @@ -35,11 +36,11 @@ If the NativeScript framework does not expose a native API that you need, you ca | |||
|
|
|||
| * The plugin must be a valid npm package. | |||
| * The plugin must expose a built-in native API or a native API available via custom native libraries. | |||
| * The plugin must be written in JavaScript or TypeScript and must comply with the CommonJS specification. If written in TypeScript, make sure to include the compiled `JavaScript` file in your plugin. | |||
| * The plugin must be written in JavaScript or TypeScript and must comply with the CommonJS specification. If written in TypeScript, make sure to include the compiled JavaScript file in your plugin. | |||
There was a problem hiding this comment.
We support Babel officially and the user can use any language which can compile to JavaScript. Consider expanding this statement to be more inclusive.
|
@teobugslayer Thank you for your comments. I've made a commit to address them 😄 |
|
Test PASSed. |
| If there are linker errors after building, you may have to link with some native frameworks described in the CocoaPod documentation. See [`build.xcconfig` file](PLUGINS.md#buildxcconfig-specification) specification on how to do this. |
There was a problem hiding this comment.
In case of post-build linker errors, you might need to resolve missing dependencies to native frameworks required by the installed CocoaPod. For more information about how to create the required links, see the build.xcconfig specification.
|
Test PASSed. |
|
👍 squash and merge. Excellent work! |
jasssonpet
force-pushed
the
jasssonpet/docs
branch
from
7d8e995 to
2012e12
Compare
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeScript/ios-jsc#427